[coreboot-gerrit] Change in coreboot[master]: sb/intel, ACPI: Do not override FADT preferred_pm_profile

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42186 )

Change subject: sb/intel, ACPI: Do not override FADT preferred_pm_profile
......................................................................

sb/intel, ACPI: Do not override FADT preferred_pm_profile

Setting preferred_pm_profile under sb/ overrides the
default determined from SYSTEM_TYPE_xx (or possibly
SMBIOS_ENCLOSURE_TYPE with followup work). This is not desireable.

Boards need to either select a pre-defined SYSTEM_TYPE_xx or provide
board-specific mainboard_fill_fadt() should they need to change this.

As they already select SYSTEM_TYPE_LAPTOP, following boards
will maintain PM_MOBILE:

lenovo/t400
  lenovo/x200
  roda/rk9

Following will change to PM_DESKTOP:

aopen/dxplplusu
  asus/p2b
  emulation/qemu-i440fx
  emulation/qemu-q35

Change-Id: I2986eb0a8abc94507e9797cc8b64611ae4bd888a
Signed-off-by: Kyösti Mälkki 
---
M src/southbridge/intel/i82371eb/fadt.c
M src/southbridge/intel/i82801dx/fadt.c
M src/southbridge/intel/i82801ix/fadt.c
3 files changed, 0 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/42186/1

diff --git a/src/southbridge/intel/i82371eb/fadt.c b/src/southbridge/intel/i82371eb/fadt.c
index 711b37e..84745a4 100644
--- a/src/southbridge/intel/i82371eb/fadt.c
+++ b/src/southbridge/intel/i82371eb/fadt.c
@@ -18,7 +18,6 @@
  */
 void acpi_fill_fadt(acpi_fadt_t *fadt)
 {
-	fadt->preferred_pm_profile = 0; /* unspecified */
    fadt->sci_int = 9;

if (permanent_smi_handler()) {
diff --git a/src/southbridge/intel/i82801dx/fadt.c b/src/southbridge/intel/i82801dx/fadt.c
index b497419..2da2175 100644
--- a/src/southbridge/intel/i82801dx/fadt.c
+++ b/src/southbridge/intel/i82801dx/fadt.c
@@ -21,7 +21,6 @@
 {
    u16 pmbase = pci_read_config16(pcidev_on_root(0x1f, 0), 0x40) & 0xfffe;

-	fadt->preferred_pm_profile = PM_UNSPECIFIED;

fadt->sci_int = 0x9;

diff --git a/src/southbridge/intel/i82801ix/fadt.c b/src/southbridge/intel/i82801ix/fadt.c
index 75d056f..ff30611 100644
--- a/src/southbridge/intel/i82801ix/fadt.c
+++ b/src/southbridge/intel/i82801ix/fadt.c
@@ -10,7 +10,6 @@
 {
    u16 pmbase = pci_read_config16(pcidev_on_root(0x1f, 0), 0x40) & 0xfffe;

-	fadt->preferred_pm_profile = PM_MOBILE;
    fadt->sci_int = 0x9;

if (permanent_smi_handler()) {