[coreboot-gerrit] [S] Change in coreboot[main]: soc/intel/common: Add low battery shutdown function

[Jérémy Compostella (Code Review)]

Attention is currently required from: Angel Pons, Intel coreboot Reviewers, Julius Werner, Karthik Ramasubramanian, Subrata Banik.

Jérémy Compostella has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/86361?usp=email )

Change subject: soc/intel/common: Add low battery shutdown function
......................................................................

Patch Set 3:

(2 comments)

File src/include/reset.h:

https://review.coreboot.org/c/coreboot/+/86361/comment/e273dfa8_6ceca119?usp... :
PS3, Line 51:  * 2. Introduces a short delay to allow time for logging.
How is the short delay allowing logging ? If this is just for logging why is it arbitrarily 3 seconds ?

File src/soc/intel/common/reset.c:

https://review.coreboot.org/c/coreboot/+/86361/comment/177976e2_418f82aa?usp... :
PS3, Line 27: void do_low_battery_shutdown(void)
I would use poweroff instead of shutdown to stay consistent with other functions introduced by this chain of CLs.