Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34642 )
Change subject: soc/intel/apl: Enable FSP usage by default ......................................................................
Patch Set 3: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/34642/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34642/3//COMMIT_MSG@7 PS3, Line 7: FSP FSP *repo* usage?
https://review.coreboot.org/c/coreboot/+/34642/1/src/mainboard/up/squared/Kc... File src/mainboard/up/squared/Kconfig:
https://review.coreboot.org/c/coreboot/+/34642/1/src/mainboard/up/squared/Kc... PS1, Line 15: default y
Done
Ack. Not part of this patch, but generally no board should select or change the default of USE_BLOBS. Otherwise, an argument could be made that it should always default to `y`. I wouldn't mind, but it defeats the purpose of that option. We could rather add a NEED_BLOBS Kconfig, then, selected by any platform / board that needs something from the repo.