Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45235 )
Change subject: libpayload: cbgfx: Fix 'equals' counter for Lanczos resampling
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45235/4/payloads/libpayload/drivers...
File payloads/libpayload/drivers/video/graphics.c:
https://review.coreboot.org/c/coreboot/+/45235/4/payloads/libpayload/drivers...
PS4, Line 883: equals > 0
nit: This extra check is unnecessary since i can never equal -1 (which actually ends up being 0xff b […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45235
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibc91ad1af85adcf093eff40797cd54f32f57111d
Gerrit-Change-Number: 45235
Gerrit-PatchSet: 5
Gerrit-Owner: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 17 Sep 2020 00:42:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment