build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34332 )
Change subject: mediatek/mt8183: support DDR frequency 3600Mbps ......................................................................
Patch Set 3:
(10 comments)
https://review.coreboot.org/c/coreboot/+/34332/3/src/soc/mediatek/mt8183/dra... File src/soc/mediatek/mt8183/dramc_init_setting.c:
https://review.coreboot.org/c/coreboot/+/34332/3/src/soc/mediatek/mt8183/dra... PS3, Line 1890: dramc_dbg("mode reg init, CH%u RK%u, freq:%d\n", chn, rank, freqTbl[freq_group]); line over 96 characters
https://review.coreboot.org/c/coreboot/+/34332/3/src/soc/mediatek/mt8183/dra... PS3, Line 1903: MR13Value = (1 <<4) | (1<<3); need consistent spacing around '<<' (ctx:WxV)
https://review.coreboot.org/c/coreboot/+/34332/3/src/soc/mediatek/mt8183/dra... PS3, Line 1933: if (operate_fsp == FSP_0) { suspect code indent for conditional statements (24, 28)
https://review.coreboot.org/c/coreboot/+/34332/3/src/soc/mediatek/mt8183/dra... PS3, Line 1933: if (operate_fsp == FSP_0) { braces {} are not necessary for any arm of this statement
https://review.coreboot.org/c/coreboot/+/34332/3/src/soc/mediatek/mt8183/dra... PS3, Line 1935: } else { suspect code indent for conditional statements (24, 28)
https://review.coreboot.org/c/coreboot/+/34332/3/src/soc/mediatek/mt8183/dra... PS3, Line 2109: .r_dmmrw_intv = 0xf, //Berson: LP3/4 both use this field -> Formula may change, set to 0xF for now line over 96 characters
https://review.coreboot.org/c/coreboot/+/34332/3/src/soc/mediatek/mt8183/dra... File src/soc/mediatek/mt8183/dramc_pi_calibration_api.c:
https://review.coreboot.org/c/coreboot/+/34332/3/src/soc/mediatek/mt8183/dra... PS3, Line 1239: virtual_delay = (((((tx_dly >> (dqs << 2)) & 0x7) << mck) + \ Avoid unnecessary line continuations
https://review.coreboot.org/c/coreboot/+/34332/3/src/soc/mediatek/mt8183/dra... PS3, Line 1240: ((dly >> (dqs << 2)) & 0x7)) << 5) + params->wr_level[chn][rank][dqs]; line over 96 characters
https://review.coreboot.org/c/coreboot/+/34332/3/src/soc/mediatek/mt8183/dra... PS3, Line 1361: dramc_dbg("win_size_sum:%d, max_win:%d, vref_dly->min_win :%d, min_win_size_vref:%d \n", unnecessary whitespace before a quoted newline
https://review.coreboot.org/c/coreboot/+/34332/3/src/soc/mediatek/mt8183/dra... PS3, Line 1766: dq_perbit_dly[bit].dqdly.best_last - dq_perbit_dly[bit].dqdly.best_first, line over 96 characters