Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43904 )
Change subject: cpu/intel/common: Fill cpu voltage in SMBIOS tables ......................................................................
Patch Set 5:
(3 comments)
https://review.coreboot.org/c/coreboot/+/43904/5/src/arch/x86/smbios.c File src/arch/x86/smbios.c:
https://review.coreboot.org/c/coreboot/+/43904/5/src/arch/x86/smbios.c@505 PS5, Line 505: } This seems unrelated. Also, the function already exists, AFAICS.
https://review.coreboot.org/c/coreboot/+/43904/5/src/cpu/intel/common/voltag... File src/cpu/intel/common/voltage.c:
https://review.coreboot.org/c/coreboot/+/43904/5/src/cpu/intel/common/voltag... PS5, Line 9: #if CONFIG(GENERATE_SMBIOS_TABLES) There is no need to guard it. If we build without SMBIOS tables, it will simply not be linked into the final binary.
https://review.coreboot.org/c/coreboot/+/43904/5/src/cpu/intel/model_2065x/K... File src/cpu/intel/model_2065x/Kconfig:
https://review.coreboot.org/c/coreboot/+/43904/5/src/cpu/intel/model_2065x/K... PS5, Line 4: if CPU_INTEL_MODEL_2065X Was this confirmed? In the SDM it's only documented since Sandy Bridge.