Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44802 )
Change subject: soc/intel/elkhartlake: Do initial SoC commit till ramstage ......................................................................
Patch Set 10:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44802/10/src/soc/intel/elkhartlake/... File src/soc/intel/elkhartlake/include/soc/gpio_defs.h:
https://review.coreboot.org/c/coreboot/+/44802/10/src/soc/intel/elkhartlake/... PS10, Line 254: define GPI_INT_STS_0 0x100 : #define GPI_INT_EN_0 0x120 : #define GPI_SMI_STS_0 0x180 : #define GPI_SMI_EN_0 0x1a0 : #define PAD_CFG_BASE 0x600 these look very wrong