Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/21774 )
Change subject: mb/dell: Add Dell Optiplex 790
......................................................................
Patch Set 63:
(3 comments)
https://review.coreboot.org/c/coreboot/+/21774/63/Documentation/mainboard/de...
File Documentation/mainboard/dell/optiplex_790.md:
https://review.coreboot.org/c/coreboot/+/21774/63/Documentation/mainboard/de...
PS63, Line 5: ## TODO
remove todo or add possibly missing info?
https://review.coreboot.org/c/coreboot/+/21774/63/Documentation/mainboard/de...
File Documentation/mainboard/dell/servicemode.md:
https://review.coreboot.org/c/coreboot/+/21774/63/Documentation/mainboard/de...
PS63, Line 7:
is the jumper connected to the Flash Descriptor Override Pin Strap?
https://review.coreboot.org/c/coreboot/+/21774/63/Documentation/mainboard/de...
PS63, Line 8: #TODO: Add a picture of the service mode jumper inside an OptiPlex 790
i'd rather add the picture to the optiplex 790 page, since the picture is specific to that device
--
To view, visit
https://review.coreboot.org/c/coreboot/+/21774
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If3d3a13163d5da1368259a7498019d42fb3ed57f
Gerrit-Change-Number: 21774
Gerrit-PatchSet: 63
Gerrit-Owner: Christoph Pomaska
github@slrie.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christoph Pomaska
github@slrie.de
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jonathan Neuschäfer
j.neuschaefer@gmx.net
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Mimoja
coreboot@mimoja.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Thomas Heijligen
src@posteo.de
Gerrit-Comment-Date: Fri, 07 Feb 2020 18:24:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment