Attention is currently required from: Subrata Banik.
Paz Zcharya has posted comments on this change by Paz Zcharya. ( https://review.coreboot.org/c/coreboot/+/86563?usp=email )
Change subject: chromeos/Kconfig: BMP_LOGO only if using FSP ......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/86563/comment/a75ffa39_e1845776?usp... : PS2, Line 11: intel-
intel
remove the `-`?
File src/vendorcode/google/chromeos/Kconfig:
https://review.coreboot.org/c/coreboot/+/86563/comment/56217051_9bc525fb?usp... : PS2, Line 84: default n
how about adding a `depends on PLATFORM_USES_FSP2_0`
But if I make that change, wouldn't it prevent the code from functioning correctly on non-FSP systems?