Attention is currently required from: Jon Murphy, Tim Van Patten, Karthik Ramasubramanian, Mark Hasemeyer.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74101 )
Change subject: mb/google/myst: Enable eSPI SCI events
......................................................................
Patch Set 7:
(1 comment)
File src/mainboard/google/myst/ec.c:
https://review.coreboot.org/c/coreboot/+/74101/comment/af3092f5_0e124306
PS6, Line 14: GEVENT_3
It does come from that sheet. […]
We use a #define on guybrush to make it easier to understand: https://review.coreboot.org/plugins/gitiles/coreboot/+/refs/heads/master/src...
Normally you can pick any GEVENT as long as it's not used. GEVENTs 0-23(?) can be mapped to GPIOs if desired, 24-31 are internal only GEVENTs. So we generally use 24+. For xhci we use 31: https://review.coreboot.org/plugins/gitiles/coreboot/+/refs/heads/master/src...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74101
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8fd858c484f6fcf952bcb4f756ba2e4728091d8b
Gerrit-Change-Number: 74101
Gerrit-PatchSet: 7
Gerrit-Owner: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Mark Hasemeyer
markhas@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Tim Van Patten
timvp@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Mark Hasemeyer
markhas@google.com
Gerrit-Comment-Date: Mon, 03 Apr 2023 21:02:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jon Murphy
jpmurphy@google.com
Comment-In-Reply-To: Tim Van Patten
timvp@google.com
Gerrit-MessageType: comment