Attention is currently required from: Garen Wu.
Ivan Chen has posted comments on this change by Garen Wu. ( https://review.coreboot.org/c/coreboot/+/82603?usp=email )
Change subject: mb/google/brox/var/greenbayupoc: Set power limit values
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/brox/variants/greenbayupoc/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/82603/comment/06513ea7_0136270c?usp... :
PS1, Line 31: .tdp_pl4 = 45,
Should it be only for no battery case rather than the default setting ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82603?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iaab808ce107251a8a8b96a77c2a636c4117621ba
Gerrit-Change-Number: 82603
Gerrit-PatchSet: 1
Gerrit-Owner: Garen Wu
wu.garen@inventec.corp-partner.google.com
Gerrit-Reviewer: Ivan Chen
yulunchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eren Peng
peng.eren@inventec.corp-partner.google.com
Gerrit-CC: Rasheed Hsueh
hsueh.rasheed@inventec.corp-partner.google.com
Gerrit-Attention: Garen Wu
wu.garen@inventec.corp-partner.google.com
Gerrit-Comment-Date: Wed, 22 May 2024 07:20:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No