22 Nov
2021
22 Nov
'21
11:47 p.m.
Attention is currently required from: Lance Zhao, Raul Rangel, Patrick Georgi, Martin Roth. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59504 )
Change subject: acpi,Makefile: Add preload_acpi_dsdt ......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Patchset:
PS2: Sorry, I won't hold up the patch forever (boot time is an important metric), I just share the same concerns stated below, largely of the fragility of sprinkling preload() calls ad-hoc throughout the code. How does one know where to stick these calls? Presumably just guess and test?
--
To view, visit https://review.coreboot.org/c/coreboot/+/59504
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibf69ecb947811a2eec861018e3ba5f858155f1c3
Gerrit-Change-Number: 59504
Gerrit-PatchSet: 2
Gerrit-Owner: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi patrick@coreboot.org
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Julius Werner jwerner@chromium.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Patrick Georgi patrick@coreboot.org
Gerrit-Attention: Martin Roth martinroth@google.com
Gerrit-Comment-Date: Mon, 22 Nov 2021 21:47:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment