Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39766 )
Change subject: drivers/i2c/nct7802y: Configure remote diodes and local sensor
......................................................................
Patch Set 32:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39766/31/src/drivers/i2c/nct7802y/n...
File src/drivers/i2c/nct7802y/nct7802y_fan.c:
https://review.coreboot.org/c/coreboot/+/39766/31/src/drivers/i2c/nct7802y/n...
PS31, Line 81: value = 0
Right, sounds good.
Done
https://review.coreboot.org/c/coreboot/+/39766/31/src/drivers/i2c/nct7802y/n...
PS31, Line 82: (i << 1)
i * 2?
Done
https://review.coreboot.org/c/coreboot/+/39766/31/src/drivers/i2c/nct7802y/n...
PS31, Line 82: i << 1
Please just write `i * 2`. This is not very readable. Also wouldn't need parentheses. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39766
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I28cc4e5cae76cf0bcdad26a50ee6cd43a201d31e
Gerrit-Change-Number: 39766
Gerrit-PatchSet: 32
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 28 Sep 2020 12:15:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment
