HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31004
Change subject: mb/(ICH7): Do not try to rewrite on V1CAP register ......................................................................
mb/(ICH7): Do not try to rewrite on V1CAP register
V1CAP is a write-once register, and it is already programmd in intel/i945/early_init.c
Change-Id: I4469cb7505d584f10c98aec579a2d78bf1950bf3 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/apple/macbook21/romstage.c M src/mainboard/getac/p470/romstage.c M src/mainboard/ibase/mb899/romstage.c M src/mainboard/intel/d945gclf/romstage.c M src/mainboard/lenovo/t60/romstage.c M src/mainboard/lenovo/x60/romstage.c M src/mainboard/lenovo/z61t/romstage.c 7 files changed, 0 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/31004/1
diff --git a/src/mainboard/apple/macbook21/romstage.c b/src/mainboard/apple/macbook21/romstage.c index ad184a8..4e1fd96 100644 --- a/src/mainboard/apple/macbook21/romstage.c +++ b/src/mainboard/apple/macbook21/romstage.c @@ -143,8 +143,6 @@ { /* V0CTL Virtual Channel 0 Resource Control */ RCBA32(0x0014) = 0x80000001; - /* V1CAP Virtual Channel 1 Resource Capability */ - RCBA32(0x001c) = 0x03128010;
/* Device 1f interrupt pin register */ RCBA32(0x3100) = 0x00042210; diff --git a/src/mainboard/getac/p470/romstage.c b/src/mainboard/getac/p470/romstage.c index 471977f..6c5b441 100644 --- a/src/mainboard/getac/p470/romstage.c +++ b/src/mainboard/getac/p470/romstage.c @@ -146,7 +146,6 @@ { /* Set up virtual channel 0 */ //RCBA32(0x0014) = 0x80000001; - //RCBA32(0x001c) = 0x03128010;
/* Device 1f interrupt pin register */ RCBA32(D31IP) = 0x00042220; diff --git a/src/mainboard/ibase/mb899/romstage.c b/src/mainboard/ibase/mb899/romstage.c index 9eaa8de..aa8878d 100644 --- a/src/mainboard/ibase/mb899/romstage.c +++ b/src/mainboard/ibase/mb899/romstage.c @@ -124,7 +124,6 @@ { /* Set up virtual channel 0 */ //RCBA32(0x0014) = 0x80000001; - //RCBA32(0x001c) = 0x03128010;
/* Device 1f interrupt pin register */ RCBA32(D31IP) = 0x00042210; diff --git a/src/mainboard/intel/d945gclf/romstage.c b/src/mainboard/intel/d945gclf/romstage.c index 5e3535a..35213a9 100644 --- a/src/mainboard/intel/d945gclf/romstage.c +++ b/src/mainboard/intel/d945gclf/romstage.c @@ -48,7 +48,6 @@ { /* Set up virtual channel 0 */ //RCBA32(0x0014) = 0x80000001; - //RCBA32(0x001c) = 0x03128010;
/* dev irq route register */ RCBA16(D31IR) = 0x0132; diff --git a/src/mainboard/lenovo/t60/romstage.c b/src/mainboard/lenovo/t60/romstage.c index 3017357..f10f447 100644 --- a/src/mainboard/lenovo/t60/romstage.c +++ b/src/mainboard/lenovo/t60/romstage.c @@ -75,7 +75,6 @@ { /* Set up virtual channel 0 */ RCBA32(V0CTL) = 0x80000001; - RCBA32(V1CAP) = 0x03128010;
/* Device 1f interrupt pin register */ RCBA32(D31IP) = 0x00001230; diff --git a/src/mainboard/lenovo/x60/romstage.c b/src/mainboard/lenovo/x60/romstage.c index 6f66c88..1a2bc28 100644 --- a/src/mainboard/lenovo/x60/romstage.c +++ b/src/mainboard/lenovo/x60/romstage.c @@ -74,7 +74,6 @@ { /* Set up virtual channel 0 */ RCBA32(V0CTL) = 0x80000001; - RCBA32(V1CAP) = 0x03128010;
/* Device 1f interrupt pin register */ RCBA32(D31IP) = 0x00001230; diff --git a/src/mainboard/lenovo/z61t/romstage.c b/src/mainboard/lenovo/z61t/romstage.c index 6eceaeb..5dae395 100644 --- a/src/mainboard/lenovo/z61t/romstage.c +++ b/src/mainboard/lenovo/z61t/romstage.c @@ -75,7 +75,6 @@ { /* Set up virtual channel 0 */ RCBA32(V0CTL) = 0x80000001; - RCBA32(V1CAP) = 0x03128010;
/* Device 1f interrupt pin register */ RCBA32(D31IP) = 0x00001230;