build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37674 )
Change subject: [WIP]util/fsp-defaults: Add tool to extract FSP UPDs from binaries ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/c/coreboot/+/37674/2/util/fsp-defaults/fspdef.h File util/fsp-defaults/fspdef.h:
https://review.coreboot.org/c/coreboot/+/37674/2/util/fsp-defaults/fspdef.h@... PS2, Line 8: void process_fsp_m_config(size_t offset, const FSP_M_CONFIG *); function definition argument 'const FSP_M_CONFIG *' should also have an identifier name
https://review.coreboot.org/c/coreboot/+/37674/2/util/fsp-defaults/fspdef.h@... PS2, Line 9: void process_fsp_m_tconfig(size_t offset, const FSP_M_TEST_CONFIG *); function definition argument 'const FSP_M_TEST_CONFIG *' should also have an identifier name
https://review.coreboot.org/c/coreboot/+/37674/2/util/fsp-defaults/fspdef.h@... PS2, Line 10: void process_fsp_s_config(size_t offset, const FSP_S_CONFIG *); function definition argument 'const FSP_S_CONFIG *' should also have an identifier name
https://review.coreboot.org/c/coreboot/+/37674/2/util/fsp-defaults/fspdef.h@... PS2, Line 11: void process_fsp_s_tconfig(size_t offset, const FSP_S_TEST_CONFIG *); function definition argument 'const FSP_S_TEST_CONFIG *' should also have an identifier name