3 Aug
2019
3 Aug
'19
5:41 p.m.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31464 )
Change subject: drivers/intel/gma: Enable Kabylake+ libgfxinit support ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/31464/5/src/drivers/intel/gma/Kconf... File src/drivers/intel/gma/Kconfig:
https://review.coreboot.org/c/coreboot/+/31464/5/src/drivers/intel/gma/Kconf... PS5, Line 70: NORTHBRIDGE_INTEL_HASWELL any reason to have this on its own line? SOC vs NORTHBRIDGE? Seems like you could condense the following 3 lines into 2 if Broadwell moved up
--
To view, visit https://review.coreboot.org/c/coreboot/+/31464
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic911bda3dd62c4d37a1b74a87fb51adc6c9d6ad4
Gerrit-Change-Number: 31464
Gerrit-PatchSet: 5
Gerrit-Owner: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org
Gerrit-Reviewer: Jens Drenhaus jens.drenhaus@9elements.com
Gerrit-Reviewer: Marcello Sylvester Bauer marcello.bauer@9elements.com
Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com
Gerrit-Reviewer: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 03 Aug 2019 17:41:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment