Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32998 )
Change subject: soc/intel/quark: Don't use CAR_GLOBAL
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/32998/4/src/soc/intel/quark/storage_test.c
File src/soc/intel/quark/storage_test.c:
https://review.coreboot.org/#/c/32998/4/src/soc/intel/quark/storage_test.c@3...
PS4, Line 34: long log_start_time;
I can't see why these are declared with extern in storage_test.h.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32998
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4e2c1c5766e3bcdd4763b42fb925074f7ccd7002
Gerrit-Change-Number: 32998
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Mon, 27 May 2019 15:01:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment