Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46432 )
Change subject: security/vboot: Make mrc_cache hash functions generic
......................................................................
Patch Set 10:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46432/10/src/security/vboot/mrc_cac...
File src/security/vboot/mrc_cache_hash_tpm.c:
https://review.coreboot.org/c/coreboot/+/46432/10/src/security/vboot/mrc_cac...
PS10, Line 27: /* We do not store normal mode data hash in TPM. */
: if (!vboot_recovery_mode_enabled())
: return;
It is not correct to drop this. It should be dropped when complete support for both rec and non-rec indexes is added.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46432
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9c0bb25eafc731ca9c7a95113ab940f55997fc0f
Gerrit-Change-Number: 46432
Gerrit-PatchSet: 10
Gerrit-Owner: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 16 Oct 2020 22:47:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment