Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38538 )
Change subject: libpayload/corebootfb: Add option to center a 80x25 console ......................................................................
Patch Set 1: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/38538/1/payloads/libpayload/Kconfig File payloads/libpayload/Kconfig:
https://review.coreboot.org/c/coreboot/+/38538/1/payloads/libpayload/Kconfig... PS1, Line 319: 80x25
That's the default that was already hardcoded (and probably the only common […]
Ack
https://review.coreboot.org/c/coreboot/+/38538/1/payloads/libpayload/drivers... File payloads/libpayload/drivers/video/corebootfb.c:
https://review.coreboot.org/c/coreboot/+/38538/1/payloads/libpayload/drivers... PS1, Line 244: /* adapt to the framebuffer size, otherwise. */
It felt like it belongs together. Let me know if you have strong feelings […]
I have more murderous feelings about the C++ style comment in line 255, so I don't think not having a blank line is too much of an issue.