[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/cannonlake: Configure SPI CS parameters in FSP UPD.

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32791 )

Change subject: soc/intel/cannonlake: Configure SPI CS parameters in FSP UPD.
......................................................................

Patch Set 4:

(2 comments)

https://review.coreboot.org/#/c/32791/4/src/soc/intel/cannonlake/fsp_params.... 
File src/soc/intel/cannonlake/fsp_params.c:

https://review.coreboot.org/#/c/32791/4/src/soc/intel/cannonlake/fsp_params.... 
PS4, Line 132: 			if (cfg.cs_polarity == SPI_POLARITY_LOW) {
braces {} are not necessary for any arm of this statement

https://review.coreboot.org/#/c/32791/4/src/soc/intel/cannonlake/fsp_params.... 
PS4, Line 414: 		configure_gspi_cs(i, config, &(params->SerialIoSpiCsPolarity[0]));
line over 80 characters