build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27518 )
Change subject: soc/intel/skylake: Use bootblock common stage ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/27518/1/src/soc/intel/skylake/bootblock/boot... File src/soc/intel/skylake/bootblock/bootblock.c:
https://review.coreboot.org/#/c/27518/1/src/soc/intel/skylake/bootblock/boot... PS1, Line 150: pci_write_config32(PCH_DEV_SMBUS, TCOBASE, TCO_BASE_ADDDRESS); 'ADDDRESS' may be misspelled - perhaps 'ADDRESS'?
https://review.coreboot.org/#/c/27518/1/src/soc/intel/skylake/bootblock/boot... PS1, Line 159: pcr_write32(PID_DMI, PCR_DMI_TCOBASE, TCO_BASE_ADDDRESS | (1 << 1)); 'ADDDRESS' may be misspelled - perhaps 'ADDRESS'?