Attention is currently required from: Subrata Banik, Paul Menzel, Tim Wawrzynczak, Kane Chen.
Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63293 )
Change subject: soc/intel/alderlake: Allow mainboard to configure USB2 Phy power gating
......................................................................
Patch Set 2:
(3 comments)
Patchset:
PS2:
I believe we need to default disable USB2 PHY power gating for all ADL-P devices irrespective of int […]
@subrata, as per Intel doc#723158, when extern VR is used, then reported issue may not occur. So, I expect developer should enable the UPD if USB2 phy power gating to be disabled.
File src/soc/intel/alderlake/chip.h:
https://review.coreboot.org/c/coreboot/+/63293/comment/585baf45_1b453fdb
PS2, Line 572: orderto
order to
Ack
https://review.coreboot.org/c/coreboot/+/63293/comment/de69f197_f38775c7
PS2, Line 572:
One space.
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63293
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3d80a3e36c6f8a3c0f174f955b11457752809f4d
Gerrit-Change-Number: 63293
Gerrit-PatchSet: 2
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Kane Chen
kane.chen@intel.com
Gerrit-Comment-Date: Fri, 01 Apr 2022 06:37:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment