Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33764 )
Change subject: soc/amd/picasso: Update all PSP and amdfw.rom building ......................................................................
Patch Set 7:
(7 comments)
https://review.coreboot.org/c/coreboot/+/33764/1/src/soc/amd/picasso/Kconfig File src/soc/amd/picasso/Kconfig:
https://review.coreboot.org/c/coreboot/+/33764/1/src/soc/amd/picasso/Kconfig... PS1, Line 287: in cbmem.
trailing whitespace
Done
https://review.coreboot.org/c/coreboot/+/33764/4/src/soc/amd/picasso/Kconfig File src/soc/amd/picasso/Kconfig:
https://review.coreboot.org/c/coreboot/+/33764/4/src/soc/amd/picasso/Kconfig... PS4, Line 335: config ROMSTAGE_MAX_SIZE : hex "Size of first execution stage" : default 0x10000 : help : The base address where romstage should be linked. This is the : uncompressed size of romstage.
Thanks. The result of many interactive rebases, I'm sure.
Done
https://review.coreboot.org/c/coreboot/+/33764/4/src/soc/amd/picasso/Makefil... File src/soc/amd/picasso/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/33764/4/src/soc/amd/picasso/Makefil... PS4, Line 128: #
Done
Done
https://review.coreboot.org/c/coreboot/+/33764/4/src/soc/amd/picasso/Makefil... PS4, Line 139: # type = 0x3 : PSPRCVR_FILE=$(top)/$(FIRMWARE_LOCATE)/PspRecoveryBootLoader_prod_RV.sbin
Removed. Let's not add it without a recovery mechanism.
Done
https://review.coreboot.org/c/coreboot/+/33764/4/src/soc/amd/picasso/Makefil... PS4, Line 148: # type = 0x9 : PSP_SEC_DBG_KEY_FILE=$(top)/$(FIRMWARE_LOCATE)/RavenSecureDebug_PublicKey.bin
No, we need this one to boot. Odd because of its name, though.
Done
https://review.coreboot.org/c/coreboot/+/33764/4/src/soc/amd/picasso/Makefil... PS4, Line 152: "0x0000000010000001"
I'm good with the comment. […]
Done
https://review.coreboot.org/c/coreboot/+/33764/4/src/soc/amd/picasso/Makefil... PS4, Line 160: # type = 0x13 : PSP_SEC_DEBUG_FILE=$(top)/$(FIRMWARE_LOCATE)/secure_unlock_prod_RV.sbin
Nope, this one's required too.
Done