Attention is currently required from: Bao Zheng, Cliff Huang, Felix Held, Fred Reitberger, Jason Glenesk, Lance Zhao, Matt DeVillier, Simon Glass, Tim Wawrzynczak, Zheng Bao.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79174?usp=email )
Change subject: soc/amd: Add DBG2 ACPI table
......................................................................
Patch Set 10:
(1 comment)
File src/soc/amd/common/block/acpi/tables.c:
https://review.coreboot.org/c/coreboot/+/79174/comment/d9142772_e5a0b715 :
PS10, Line 15: current = acpi_16550_mmio32_write_dbg2_uart(rsdp, current,
You need to guard this with `if CONFIG(AMD_SOC_CONSOLE_UART)`
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79174?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3c97a78d1889549421baf0bc1a2e8f959a0f47e2
Gerrit-Change-Number: 79174
Gerrit-PatchSet: 10
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Simon Glass
sjg@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: Bao Zheng
fishbaozi@gmail.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Simon Glass
sjg@chromium.org
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 29 Nov 2023 16:20:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment