build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47388 )
Change subject: soc/intel/elkhartlake: Adding PSE TSN support & PSE UPDs configs ......................................................................
Patch Set 4:
(4 comments)
https://review.coreboot.org/c/coreboot/+/47388/4/src/soc/intel/elkhartlake/K... File src/soc/intel/elkhartlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/47388/4/src/soc/intel/elkhartlake/K... PS4, Line 236: string "TSN MAC adress binary path and filename" 'adress' may be misspelled - perhaps 'address'?
https://review.coreboot.org/c/coreboot/+/47388/4/src/soc/intel/elkhartlake/K... PS4, Line 239: The path and filename of the TSN mac adress binary. 'adress' may be misspelled - perhaps 'address'?
https://review.coreboot.org/c/coreboot/+/47388/4/src/soc/intel/elkhartlake/f... File src/soc/intel/elkhartlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/47388/4/src/soc/intel/elkhartlake/f... PS4, Line 104: if (CONFIG(ENABLE_TSN)){ suspect code indent for conditional statements (8, 8)
https://review.coreboot.org/c/coreboot/+/47388/4/src/soc/intel/elkhartlake/f... PS4, Line 104: if (CONFIG(ENABLE_TSN)){ space required before the open brace '{'