Piotr Kleinschmidt has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35482 )
Change subject: superio/nuvoton/nct5104d: soft reset GPIO
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35482/2/src/superio/nuvoton/nct5104...
File src/superio/nuvoton/nct5104d/superio.c:
https://review.coreboot.org/c/coreboot/+/35482/2/src/superio/nuvoton/nct5104...
PS2, Line 142:
: if (gpio0_enabled)
: pnp_write_config(dev, NCT5104D_GPIO0_PP_OD, 0xFF);
:
: if (gpio1_enabled)
: pnp_write_config(dev, NCT5104D_GPIO1_PP_OD, 0xFF);
:
: if (gpio6_enabled)
: pnp_write_config(dev, NCT5104D_GPIO6_PP_OD, 0xFF);
do these writes need to be conditional? if so I'd rather use the information from the devicetree
Yes, they do. We want to reset only enabled gpio banks.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35482
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I67878dbab2ddf0deaaa8f5d79416368c6164ba1d
Gerrit-Change-Number: 35482
Gerrit-PatchSet: 2
Gerrit-Owner: Piotr Kleinschmidt
piotr.kleinschmidt@3mdeb.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Piotr Kleinschmidt
piotr.kleinschmidt@3mdeb.com
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 18 Nov 2019 09:55:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment