Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41719 )
Change subject: amd/picasso: Load x86 microcode from CBFS modules ......................................................................
Patch Set 14:
(7 comments)
Patch Set 12:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41719/10/src/soc/amd/picasso/microc... File src/soc/amd/picasso/microcode_picasso.c:
https://review.coreboot.org/c/coreboot/+/41719/10/src/soc/amd/picasso/microc... PS10, Line 13: struct microcode {
this struct might need to be marked as packed, because it is used to access to deserialize a data bl […]
Done. Add __packed.
https://review.coreboot.org/c/coreboot/+/41719/10/src/soc/amd/picasso/microc... PS10, Line 31:
remove extra blank line
Done. removed.
https://review.coreboot.org/c/coreboot/+/41719/10/src/soc/amd/picasso/microc... PS10, Line 39: /* apply patch */
I think the source is OK without the comment.
Done. Removed.
https://review.coreboot.org/c/coreboot/+/41719/10/src/soc/amd/picasso/microc... PS10, Line 48: /* patch authentication */
authentication? it's more a check if the new ucode was successfully applied. […]
// Do ucode patch Authentication These are the words from AGESA source.
https://review.coreboot.org/c/coreboot/+/41719/10/src/soc/amd/picasso/microc... PS10, Line 57:
remove extra space
Done
https://review.coreboot.org/c/coreboot/+/41719/10/src/soc/amd/picasso/microc... PS10, Line 68: uint32_t
uintptr_t
Done. Changed.
https://review.coreboot.org/c/coreboot/+/41719/10/src/soc/amd/picasso/microc... PS10, Line 68: F17H_MPB_MAX_SIZE
still need to remove the F17h stuff
What should it be? PICASSO_MPB_MAX_SIZE?