Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39221 )
Change subject: vboot: Clean up pre-RAM use of vboot_recovery_mode_enabled()
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39221/2/src/drivers/mrc_cache/mrc_c...
File src/drivers/mrc_cache/mrc_cache.c:
https://review.coreboot.org/c/coreboot/+/39221/2/src/drivers/mrc_cache/mrc_c...
PS2, Line 522: if (!CONFIG(VBOOT_STARTS_IN_BOOTBLOCK))
This isn't the same thing, this is CONFIG(MRC_CLEAR_NORMAL_CACHE_ON_RECOVERY_RETRAIN). You're right, if I add a dependency on that I can get rid of the check here. But the other checks (above and in other files) would still be staying.
Unless I'm missing something -- hasn't this always been the case for non-manual recovery?
No, because it used to call get_recovery_mode_from_vbnv().
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39221
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I31bfc7663724fdacab9955224dcaf650d1ec1c3c
Gerrit-Change-Number: 39221
Gerrit-PatchSet: 2
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Frans Hendriks
fhendriks@eltan.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 04 Mar 2020 20:41:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joel Kitching
kitching@google.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment