Attention is currently required from: Subrata Banik, Tim Wawrzynczak, Nick Vaccaro, AlanKY Lee.
YH Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67929 )
Change subject: mb/google/brya/var/skolas: sync brya0 and skolas FW_CONFIG defs
......................................................................
Patch Set 2:
(2 comments)
File src/mainboard/google/brya/variants/brya0/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/67929/comment/6f1618f6_218a562e
PS2, Line 29: option UFC_MIPI_OVTI5675 1
: option UFC_MIPI_IMX208 2
Only UFC_MIPI_OVTI5675 (value 1) seems to be used in Brya.
UFC_MIPI_IMX208 doesn't seem to be referenced.
https://review.coreboot.org/c/coreboot/+/67929/comment/c7ae4869_4faba6a0
PS2, Line 34: option WFC_MIPI_OVTI8856 1
: option WFC_MIPI_KBAE350 2
Only WFC_MIPI_OVTI8856 (value 1) seems to be used in Brya.
Neither WFC_MIPI_OVTI5675 nor WFC_MIPI_KBAE350 being referenced.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/67929
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3be26e0a05f4dc08e5dc3f6ef7b71bdd8fd4f859
Gerrit-Change-Number: 67929
Gerrit-PatchSet: 2
Gerrit-Owner: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: AlanKY Lee
alanky_lee@compal.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: YH Lin
yueherngl@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: AlanKY Lee
alanky_lee@compal.corp-partner.google.com
Gerrit-Comment-Date: Fri, 30 Sep 2022 21:00:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment