Attention is currently required from: Jonathan Zhang, Stefan Reinauer, David Hendricks, Angel Pons, Subrata Banik, TsungHo Wu, Kyösti Mälkki, Patrick Rudolph, ron minnich.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50374 )
Change subject: superio/aspeed: setup early serial for AST2600
......................................................................
Patch Set 4:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/50374/comment/a2ba76dd_8dbd485f
PS4, Line 7: setup
Set up
https://review.coreboot.org/c/coreboot/+/50374/comment/061a6c9e_8816cd2c
PS4, Line 23: Change-Id: Ib21b054bea2e64e00521807e8aa13e536f643974
Please move this right above the Signed-off-by lines.
File src/superio/aspeed/ast2400/ast2400.h:
https://review.coreboot.org/c/coreboot/+/50374/comment/d21b28e4_d2c30825
PS4, Line 16: #define AST2600_CHIP_ID_REG 0x20
Please align with tabs as above?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50374
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib21b054bea2e64e00521807e8aa13e536f643974
Gerrit-Change-Number: 50374
Gerrit-PatchSet: 4
Gerrit-Owner: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Daocheng Bu
daocheng.bu@intel.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: TsungHo Wu
tsungho.wu@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: David Hendricks
david.hendricks@gmail.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: TsungHo Wu
tsungho.wu@gmail.com
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: ron minnich
rminnich@gmail.com
Gerrit-Comment-Date: Sun, 07 Mar 2021 17:34:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
