Attention is currently required from: Hung-Te Lin, Rex-BC Chen, Angel Pons, Yu-Ping Wu.
Jianjun Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63019 )
Change subject: soc/mediatek: Add early_init for passing data across sessions
......................................................................
Patch Set 7:
(1 comment)
File src/soc/mediatek/common/early_init.c:
https://review.coreboot.org/c/coreboot/+/63019/comment/feb9322e_73f6153c
PS7, Line 10: assert(sizeof(struct early_init_data) <= REGION_SIZE(early_init_data));
Does it compile if we use _Static_assert() in early_init. […]
Still build failed with same error:
src/soc/mediatek/common/include/soc/early_init.h:22:47: error: expression in static assertion is not constant
22 | _Static_assert(sizeof(struct early_init_data) <= REGION_SIZE(early_init_data));
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63019
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I01f91b7fe2cbe4f73b5c616bb7aae778dee27d9a
Gerrit-Change-Number: 63019
Gerrit-PatchSet: 7
Gerrit-Owner: Jianjun Wang
jianjun.wang@mediatek.corp-partner.google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Mon, 28 Mar 2022 02:22:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment