Attention is currently required from: Xi Chen, Paul Menzel, Angel Pons, CK HU, Yidi Lin. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44716 )
Change subject: soc/mediatek/mt8192: Do dramc command bus training ......................................................................
Patch Set 56:
(12 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/44716/comment/273f1563_9d38c649 PS56, Line 10: , : t . T
File src/soc/mediatek/mt8192/dramc_pi_calibration_api.c:
https://review.coreboot.org/c/coreboot/+/44716/comment/ccf0a580_648aebe6 PS42, Line 602: Per
per bit, which means CA per bit delay line
Ack
https://review.coreboot.org/c/coreboot/+/44716/comment/4f0af84d_ff8348e6 PS42, Line 634: 0xF
only 3 bits, use 0x7.
Ack
https://review.coreboot.org/c/coreboot/+/44716/comment/51111234_a0c9c456 PS42, Line 666: capi
ca pi per clock: 64(freq > 400), 32(freq == 400) […]
Ack
https://review.coreboot.org/c/coreboot/+/44716/comment/0f0e952b_be4ef648 PS42, Line 684: ratio
The possible values of ratio is 0 or 1, changed to u8.
Ack
https://review.coreboot.org/c/coreboot/+/44716/comment/8be0b6bd_5b734d45 PS42, Line 687: cbtui
yes, cbt_ui, change to get_cbt_ui_limit
Ack
https://review.coreboot.org/c/coreboot/+/44716/comment/21d948b4_002702c0 PS42, Line 748: p2u
remove it, use macro.
Ack
https://review.coreboot.org/c/coreboot/+/44716/comment/646f7ae5_0b7a7d71 PS42, Line 754: d
Done, also change s16 pi_dly to u8 pi_dly.
Ack
File src/soc/mediatek/mt8192/dramc_pi_calibration_api.c:
https://review.coreboot.org/c/coreboot/+/44716/comment/0aa1aefa_f430dc37 PS44, Line 597: prebit
yes, has fixed to perbit.
Ack
File src/soc/mediatek/mt8192/dramc_pi_calibration_api.c:
https://review.coreboot.org/c/coreboot/+/44716/comment/bf2c69cf_745f4840 PS56, Line 597: ) Move to previous line.
https://review.coreboot.org/c/coreboot/+/44716/comment/cd00bc09_14fe2d2f PS56, Line 748: get_capi_max:%d get_ca_pi_max_per_clock: %d
https://review.coreboot.org/c/coreboot/+/44716/comment/298bf9c3_8d21cc8d PS56, Line 817: final_ca_clk = cmd_dly; Unnecessary assignment