Attention is currently required from: Daisuke Nojiri, Nick Vaccaro, Boris Mittelberg.
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69368 )
Change subject: ec/google/chromeec: Fix keyboard_backlight call
......................................................................
Patch Set 2:
(1 comment)
File src/ec/google/chromeec/ec.c:
https://review.coreboot.org/c/coreboot/+/69368/comment/3f8cc79e_ecee7347
PS1, Line 80: struct ec_response_pwm_get_keyboard_backlight resp = {};
Can you remove this?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69368
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5b9a0d228e187a9337498246a3b9ed8db07b95c7
Gerrit-Change-Number: 69368
Gerrit-PatchSet: 2
Gerrit-Owner: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Boris Mittelberg
bmbm@google.com
Gerrit-Reviewer: Daisuke Nojiri
dnojiri@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Daisuke Nojiri
dnojiri@chromium.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Boris Mittelberg
bmbm@google.com
Gerrit-Comment-Date: Tue, 08 Nov 2022 20:05:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Daisuke Nojiri
dnojiri@chromium.org
Gerrit-MessageType: comment