Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45867 )
Change subject: security/intel/txt: Print chipset as hex value ......................................................................
Patch Set 4: Code-Review+2
(3 comments)
https://review.coreboot.org/c/coreboot/+/45867/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45867/1//COMMIT_MSG@7 PS1, Line 7: security/intel/txt: Style fixes
Please make it a statement by using a verb (in imperative mood): […]
Done
https://review.coreboot.org/c/coreboot/+/45867/1//COMMIT_MSG@11 PS1, Line 11: more readable.
Please make it two commits.
Ack
https://review.coreboot.org/c/coreboot/+/45867/1/src/security/intel/txt/txt_... File src/security/intel/txt/txt_register.h:
https://review.coreboot.org/c/coreboot/+/45867/1/src/security/intel/txt/txt_... PS1, Line 26: TXT_ERROR
The previous align was correct. Only bitfields within the register have two spaces. […]
Ack