Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31160 )
Change subject: soc/amd/stoneyridge: Reboot if missing MRC cache info
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/31160/2/src/soc/amd/common/block/s3/s3_resum...
File src/soc/amd/common/block/s3/s3_resume.c:
https://review.coreboot.org/#/c/31160/2/src/soc/amd/common/block/s3/s3_resum...
PS2, Line 50: size
And do we need to check the full size? Would 16 or 32 bytes be sufficient?
Good call. It's not like we're trying to fully check the integrity, although that might be a nice todo.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31160
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib3cf2515f300decd3de198f7741660d95ee4c744
Gerrit-Change-Number: 31160
Gerrit-PatchSet: 2
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 31 Jan 2019 15:44:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Gerrit-MessageType: comment