Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/em100/+/35947 )
Change subject: em100: Detect emulated flash chip ......................................................................
Patch Set 3:
(7 comments)
https://review.coreboot.org/c/em100/+/35947/1/em100.c File em100.c:
https://review.coreboot.org/c/em100/+/35947/1/em100.c@570 PS1, Line 570: get_chip_init_val
Function comment. […]
Done
https://review.coreboot.org/c/em100/+/35947/1/em100.c@585 PS1, Line 585: get_chip_type
Comment
Done
https://review.coreboot.org/c/em100/+/35947/1/em100.c@596 PS1, Line 596: chipdesc
Move decl to top of function
Done
https://review.coreboot.org/c/em100/+/35947/1/em100.c@597 PS1, Line 597: {
Can this be a for loop? The (++chip)->name is a bit ugly
Done
https://review.coreboot.org/c/em100/+/35947/1/em100.c@599 PS1, Line 599: 0x23, 0x40
What are these values?
Added a define for 0x40 and 0x42.
https://review.coreboot.org/c/em100/+/35947/1/em100.c@874 PS1, Line 874: const
blank line after
Done
https://review.coreboot.org/c/em100/+/35947/1/em100.c@875 PS1, Line 875: if (!get_chip_type(&em100, ¤t))
But this also prints something out so the name is confusing. […]
Done