Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31997 )
Change subject: src/arch: An upgrade of SMBIOS to latest version 3.2
......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/#/c/31997/2/src/arch/x86/smbios.c
File src/arch/x86/smbios.c:
https://review.coreboot.org/#/c/31997/2/src/arch/x86/smbios.c@606
PS2, Line 606: 0x0200
#define in smbios.h?
https://review.coreboot.org/#/c/31997/2/src/arch/x86/smbios.c@607
PS2, Line 607: 0x0100
#define in smbios.h?
https://review.coreboot.org/#/c/31997/2/src/arch/x86/smbios.c@609
PS2, Line 609: 255
maybe "#define BYTE_LIMIT 255" on smbios.h, and use BYTE_LIMIT here?
https://review.coreboot.org/#/c/31997/2/src/arch/x86/smbios.c@611
PS2, Line 611: 255
BYTE_LIMIT?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31997
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iab98e063874c9738e48a387cd91341d266391156
Gerrit-Change-Number: 31997
Gerrit-PatchSet: 2
Gerrit-Owner: Francois Toguo Fotso
francois.toguo.fotso@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Francois Toguo Fotso
francois.toguo.fotso@intel.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Francois Toguo Fotso
francois.toguo.fotso@intel.corp-partner.google.com
Gerrit-Comment-Date: Wed, 20 Mar 2019 21:07:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment