build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59558 )
Change subject: mb/google/zork/var/shuboz: Add fw_config probe for ALC5682-VD & VS ......................................................................
Patch Set 2:
(7 comments)
File src/mainboard/google/zork/variants/shuboz/variant.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134076): https://review.coreboot.org/c/coreboot/+/59558/comment/a52544e9_c1bec26e PS2, Line 84: ARRAY_SIZE(machine_dev_path)); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134076): https://review.coreboot.org/c/coreboot/+/59558/comment/86114da9_8577bba7 PS2, Line 84: ARRAY_SIZE(machine_dev_path)); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134076): https://review.coreboot.org/c/coreboot/+/59558/comment/36f34ed7_2cca0297 PS2, Line 87: if (!machine_dev || (machine_dev->chip_ops != trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134076): https://review.coreboot.org/c/coreboot/+/59558/comment/943d510f_8d7298e2 PS2, Line 88: &drivers_amd_i2s_machine_dev_ops) || !machine_dev->chip_info) { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134076): https://review.coreboot.org/c/coreboot/+/59558/comment/943ab940_90b7fb87 PS2, Line 88: &drivers_amd_i2s_machine_dev_ops) || !machine_dev->chip_info) { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134076): https://review.coreboot.org/c/coreboot/+/59558/comment/de79708c_c1bfb99e PS2, Line 99: machine_dev_config->hid); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134076): https://review.coreboot.org/c/coreboot/+/59558/comment/667dd7ec_15119628 PS2, Line 99: machine_dev_config->hid); please, no spaces at the start of a line