David Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35131 )
Change subject: mb/google/hatch/var/kindred: Update DPTF parameters and TDP PL1/PL2
......................................................................
Patch Set 2:
Patch Set 2: Code-Review+2
LGTM, but this is a bigger ACPI change, did you double check for malformed table errors in kernel logs?
How to check for malformed table errors in kernel logs ?
We have found new thermal sensor (TSR2) in DUT after updated coreboot and ec. Thanks.
localhost ~ # grep . /sys/class/thermal/t*/type
/sys/class/thermal/thermal_zone0/type:x86_pkg_temp
/sys/class/thermal/thermal_zone1/type:INT3400 Thermal
/sys/class/thermal/thermal_zone2/type:TSR0
/sys/class/thermal/thermal_zone3/type:TSR1
/sys/class/thermal/thermal_zone4/type:TSR2
/sys/class/thermal/thermal_zone5/type:TCPU
/sys/class/thermal/thermal_zone6/type:iwlwifi
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35131
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1817e277f4641db6bedc8b640b1dc5d57502d5dd
Gerrit-Change-Number: 35131
Gerrit-PatchSet: 2
Gerrit-Owner: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jack Lai
jack.lai@intel.com
Gerrit-Reviewer: Jamie Chen
jamie.chen@intel.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@google.com
Gerrit-Reviewer: Philip Chen
philipchen@google.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Grace Kao
grace.kao@intel.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 29 Aug 2019 06:11:33 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment