Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35781 )
Change subject: soc/skl/vr_config: fix GT Loadline for KBL-U/GT3
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35781/1/src/soc/intel/skylake/vr_co...
File src/soc/intel/skylake/vr_config.c:
https://review.coreboot.org/c/coreboot/+/35781/1/src/soc/intel/skylake/vr_co...
PS1, Line 289: loadline[VR_GT_UNSLICED] = VR_CFG_MOHMS(2);
can you explain how to decode the referenced datasheet.
I would use 6 here as it states that for GTX which is GT3.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35781
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I433036e76d456a725ab27cf57c9bc2fe01a7ace1
Gerrit-Change-Number: 35781
Gerrit-PatchSet: 1
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 03 Oct 2019 16:40:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment