Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35239 )
Change subject: hatch: automate creating a new variant in coreboot ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35239/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/scripts/create_coreboot_variant.sh:
https://review.coreboot.org/c/coreboot/+/35239/1/src/mainboard/google/hatch/... PS1, Line 136: git add KConfig KConfig.name : : # Now commit the files : git commit -m "${base,,}: Create ${variant,,} variant : : BUG=none : TEST=util/abuild/abuild -p none -t google/${base,,} -x -a : make sure the build includes GOOGLE_{variant^^} : : Signed-off-by: ${name} <${email}>"
How many commits do we plan to stack together when running the completed script(s)?
Six. The various files that need to be added or changed all live in different repos (plus the coreboot CL needs to be upstreamed into the chromiumos tree), and they have to happen in a certain order as well to make it through CQ.