Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41988 )
Change subject: chromeos/cr50_enable_update.c: Modify recovery flow for cr50 ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41988/2/src/vendorcode/google/chrom... File src/vendorcode/google/chromeos/cr50_enable_update.c:
https://review.coreboot.org/c/coreboot/+/41988/2/src/vendorcode/google/chrom... PS2, Line 77: * spooled by recovery_reason := VB2_RECOVERY_TRAIN_AND_REBOOT. nit: This still doesn't really explain why it's checking for FORCE_RECOVERY. How about
/* Never update during manually-triggered recovery to ensure update cannot interfere. Non-manual VB2_RECOVERY_TRAIN_AND_REBOOT sometimes used to update in factory. */