Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33993 )
Change subject: mainboard/amd: Add padmelon board code ......................................................................
Patch Set 3:
(2 comments)
You should be able to include the blob
https://review.coreboot.org/c/coreboot/+/33993/2/src/mainboard/amd/padmelon/... File src/mainboard/amd/padmelon/Kconfig:
https://review.coreboot.org/c/coreboot/+/33993/2/src/mainboard/amd/padmelon/... PS2, Line 37: config VGA_BIOS_FILE : string : default "3rdparty/blobs/soc/amd/merlinfalcon/VBIOS.bin" Leave this section in, and just point to a stoney binary for now.
https://review.coreboot.org/c/coreboot/+/33993/3/src/mainboard/amd/padmelon/... File src/mainboard/amd/padmelon/Kconfig:
https://review.coreboot.org/c/coreboot/+/33993/3/src/mainboard/amd/padmelon/... PS3, Line 20: # select SOC_AMD_MERLINFALCON # missing binaries By doing this, you're not testing any of the merlinfalcon code you've pushed.
Just update the config AGESA_BINARY_PI_FILE to point to a stoney one.
I'd also create an option like "MERLINFALCON_BINARIES_PRESENT" and default it to N then set the correct binaries if it's set to Y. That way you can use the correct binaries just by updating a config instead of having to edit the .config file.