Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39900 )
Change subject: configs: add ASUS A88XM-E sample configuration ......................................................................
Patch Set 1:
(6 comments)
OK, I don't mind that you disable support for Intel Wi-Fi here.
https://review.coreboot.org/c/coreboot/+/39900/1//COMMIT_MSG Commit Message:
PS1: The maximum line width for commit messages is 72 characters
https://review.coreboot.org/c/coreboot/+/39900/1//COMMIT_MSG@9 PS1, Line 9: .config You should provide a defconfig instead. You can get one by running:
make savedefconfig
https://review.coreboot.org/c/coreboot/+/39900/1//COMMIT_MSG@9 PS1, Line 9: by saving it : to ./coreboot/.config I think that is explained somewhere in the documentation
https://review.coreboot.org/c/coreboot/+/39900/1//COMMIT_MSG@10 PS1, Line 10: ' No apostrophe
https://review.coreboot.org/c/coreboot/+/39900/1//COMMIT_MSG@12 PS1, Line 12: AHCI Why isn't AHCI default everywhere?
https://review.coreboot.org/c/coreboot/+/39900/1//COMMIT_MSG@13 PS1, Line 13: No spaces inside parentheses, please