[coreboot-gerrit] Patch set updated for coreboot: c896acf PDCurses: pdcscrn.c: Use `#ifdef` instead of `#if CONFIG_SPEAKER`

[Paul Menzel]

Paul Menzel ([e-mail]) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2934

-gerrit

commit c896acf51810403b6bd37f368659eec95c6128bd
Author: Paul Menzel 
Date:   Wed Mar 27 09:50:30 2013 +0100

PDCurses: pdcscrn.c: Use `#ifdef` instead of `#if CONFIG_SPEAKER`

Building libpayload with the PDCurses backend the following warning
    is shown.

/src/coreboot/payloads/libpayload(master) $ make clean
        /src/coreboot/payloads/libpayload(master) $ make
        […]
            CC         curses/pdcurses-backend/pdcscrn.libcurses.o
        curses/pdcurses-backend/pdcscrn.c: In function 'PDC_scr_open':
        curses/pdcurses-backend/pdcscrn.c:75:5: warning: "CONFIG_SPEAKER" is not defined [-Wundef]
        […]

The GCC documentation states [1]

In some contexts this shortcut is undesirable. The -Wundef option
        causes GCC to warn whenever it encounters an identifier which is
        not a macro in an ‘#if’.

and therefore use `#ifdef` [2] to silence this warning. No functional
    change is done, as `CONFIG_SPEAKER` is assigned the value `Y` when
    defined.

There was some discussion going on the list [3], but my points in there
    turned out to be incorrect.

[1] http://gcc.gnu.org/onlinedocs/cpp/If.html
    [2] http://gcc.gnu.org/onlinedocs/cpp/Ifdef.html
    [3] http://www.coreboot.org/pipermail/coreboot/2013-March/075561.html

Change-Id: I8e9c9b5d01985b21ad05018986d614cf9bf2b439
    Signed-off-by: Paul Menzel 
---
 payloads/libpayload/curses/pdcurses-backend/pdcscrn.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/payloads/libpayload/curses/pdcurses-backend/pdcscrn.c b/payloads/libpayload/curses/pdcurses-backend/pdcscrn.c
index d3f1849..e741b15 100644
--- a/payloads/libpayload/curses/pdcurses-backend/pdcscrn.c
+++ b/payloads/libpayload/curses/pdcurses-backend/pdcscrn.c
@@ -72,7 +72,7 @@ int PDC_scr_open(int argc, char **argv)
     SP->lines = PDC_get_rows();
     SP->cols = PDC_get_columns();

-#if CONFIG_SPEAKER
+#ifdef CONFIG_SPEAKER
     SP->audible = TRUE;
 #endif