Kangheui Won has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45059 )
Change subject: soc/amd/picasso: pass verstage timestamps to x86 ......................................................................
Patch Set 4:
(4 comments)
https://review.coreboot.org/c/coreboot/+/45059/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45059/3//COMMIT_MSG@8 PS3, Line 8: : Remove stubs for psp_verstage and
This was moved to the other patch.
Done
https://review.coreboot.org/c/coreboot/+/45059/2/src/soc/amd/picasso/bootblo... File src/soc/amd/picasso/bootblock/bootblock.c:
https://review.coreboot.org/c/coreboot/+/45059/2/src/soc/amd/picasso/bootblo... PS2, Line 123: #if CONFIG(VBOOT_STARTS_BEFORE_BOOTBLOCK)
That shouldn't be guarded by an #if either.
Done
https://review.coreboot.org/c/coreboot/+/45059/3/src/soc/amd/picasso/bootblo... File src/soc/amd/picasso/bootblock/bootblock.c:
https://review.coreboot.org/c/coreboot/+/45059/3/src/soc/amd/picasso/bootblo... PS3, Line 123: #if CONFIG(VBOOT_STARTS_BEFORE_BOOTBLOCK)
Instead of letting the preprocessor do this, can this be done in C?
Done
https://review.coreboot.org/c/coreboot/+/45059/3/src/soc/amd/picasso/bootblo... PS3, Line 157: bootblock_main_with_basetime(base_timestamp);
As I noted before line 154 and this should be collapsed as well as removing #if conditionals.
Done