Attention is currently required from: Johnny Lin, Angel Pons, Arthur Heymans.
Shuming Chu (Shuming) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69198 )
Change subject: include/cper.h: Add CPER Memory Error Section definitions
......................................................................
Patch Set 4:
(2 comments)
File src/include/cper.h:
https://review.coreboot.org/c/coreboot/+/69198/comment/88422d73_f31896b9
PS3, Line 400: enum cper_err_code mem_err_type;
Will this work properly? Not sure if the size of enum types is well-defined. […]
Done
https://review.coreboot.org/c/coreboot/+/69198/comment/c8fafa4b_7865a8ee
PS3, Line 405: __packed
This is not needed. All entries seem aligned.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69198
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0a165350a16a4cbe4033a3e7c43fa23a5b27c44b
Gerrit-Change-Number: 69198
Gerrit-PatchSet: 4
Gerrit-Owner: Shuming Chu (Shuming)
s1218944@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Wed, 16 Nov 2022 08:56:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment