[coreboot-gerrit] New patch to review for coreboot: AGESA: Log if memory training result cannot be stored

[Kyösti Mälkki]

Kyösti Mälkki ([e-mail]) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18534

-gerrit

commit cb7471f40962c40652937a43ee1d476711666fc2
Author: Kyösti Mälkki 
Date:   Sat Nov 26 16:15:09 2016 +0200

AGESA: Log if memory training result cannot be stored

A problem around CAR teardown time may result with missing
    training results at the time we want to save them.

Record this in the logs for debugging purposes, it will
    not be possible to use S3 suspend if this happens.

Change-Id: Id2ba8facbd5d90fe3ed9c6900628309c226c2454
    Signed-off-by: Kyösti Mälkki 
---
 src/northbridge/amd/agesa/oem_s3.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/northbridge/amd/agesa/oem_s3.c b/src/northbridge/amd/agesa/oem_s3.c
index c7d23ff..fec102d 100644
--- a/src/northbridge/amd/agesa/oem_s3.c
+++ b/src/northbridge/amd/agesa/oem_s3.c
@@ -125,6 +125,8 @@ AGESA_STATUS OemS3Save(AMD_S3SAVE_PARAMS *S3SaveParams)
    if (size && dataBlock->NvStorageSize)
    	spi_SaveS3info(pos, size, dataBlock->NvStorage,
    		dataBlock->NvStorageSize);
+	else
+		printk(BIOS_EMERG, "MISSING MEMORY TRAINING DATA\n");

/* To be consumed in AmdS3LateRestore. */
    char *heap = cbmem_add(CBMEM_ID_RESUME_SCRATCH, HIGH_MEMORY_SCRATCH);