Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35726 )
Change subject: drivers/aspeed/common: Add support for high resolution framebuffer ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35726/4/src/drivers/aspeed/ast2050/... File src/drivers/aspeed/ast2050/Kconfig:
https://review.coreboot.org/c/coreboot/+/35726/4/src/drivers/aspeed/ast2050/... PS4, Line 4: select HAVE_VGA_TEXT_FRAMEBUFFER This was just wrong, it should only be selected if the user activated the driver, i.e. enabled NGI in `.config`. This was covered up by the first boards with this driver as they force NGI.
https://review.coreboot.org/c/coreboot/+/35726/4/src/drivers/aspeed/common/K... File src/drivers/aspeed/common/Kconfig:
https://review.coreboot.org/c/coreboot/+/35726/4/src/drivers/aspeed/common/K... PS4, Line 3: select HAVE_LINEAR_FRAMEBUFFER : select HAVE_VGA_TEXT_FRAMEBUFFER `if MAINBOARD_DO_NATIVE_VGA_INIT` for both, please.