Attention is currently required from: Haribalaraman Ramasubramanian, Dinesh Gehlot, Paul Menzel, Rizwan Qureshi, Reka Norman.
Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74005 )
Change subject: soc/intel/cmd/block: Implement an API to get firmware partition details ......................................................................
Patch Set 29:
(5 comments)
File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/74005/comment/d05d7c10_3d422c52 PS28, Line 1242: fw partition request
Ack
Looks like you are not honored the comment, but you acknowledged it!
https://review.coreboot.org/c/coreboot/+/74005/comment/6d017009_63f9cdbb PS28, Line 1250: partition
Ack
here too...!
https://review.coreboot.org/c/coreboot/+/74005/comment/1d09f739_2cb1318e PS28, Line 1269: if (id == FPT_PARTITION_NAME_ISHC && !CONFIG(DRIVERS_INTEL_ISH)) { : printk(BIOS_INFO, "CSE: Info request denied, no ISH partition\n"); : return false; : } :
We could move the check to another location, but I believe it is best to perform all checks before c […]
Agree!
File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/74005/comment/79242780_f5a2b251 PS29, Line 1258: if (vboot_recovery_mode_enabled()) { At least the check CONFIG(VBOOT) to be combined with vboot_recovery_mode_enabled() since verified boot may not be used in non-chromeOS platforms.
https://review.coreboot.org/c/coreboot/+/74005/comment/c5f83a87_13d161cf PS29, Line 1259: nfo request denied, request during recovery mode nit: I would prefer adding "Skip sending Get Image Info command during recovery mode"!